-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add initialBandwidth option at the tech level #1122
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1122 +/- ##
=======================================
Coverage 86.15% 86.15%
=======================================
Files 39 39
Lines 9252 9254 +2
Branches 2114 2115 +1
=======================================
+ Hits 7971 7973 +2
Misses 1281 1281
Continue to review full report at Codecov.
|
I wonder if we should deprecate |
this.clock.tick(1); | ||
|
||
openMediaSource(this.player, this.clock); | ||
assert.equal(this.player.tech_.vhs.bandwidth, 0, 'set bandwidth to 0'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda minor, but here and below, the test values being only 0 may run into issues if bandwidth is ever initialized in the future.
@@ -511,6 +511,12 @@ class VhsHandler extends Component { | |||
videojs.log.warn('Using hls options is deprecated. Use vhs instead.'); | |||
} | |||
|
|||
// if a tech level `initialBandwidth` option was passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth documentating and mentioning that it takes precedence over VHS level bandwidth
but not source level bandwidth
.
No description provided.