feat: add initialBandwidth option at the tech level #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1122 +/- ##
=======================================
Coverage 86.15% 86.15%
=======================================
Files 39 39
Lines 9252 9254 +2
Branches 2114 2115 +1
=======================================
+ Hits 7971 7973 +2
Misses 1281 1281
Continue to review full report at Codecov.
|
brandonocasey
approved these changes
Apr 27, 2021
|
I wonder if we should deprecate |
gesinger
reviewed
Apr 27, 2021
| this.clock.tick(1); | ||
|
|
||
| openMediaSource(this.player, this.clock); | ||
| assert.equal(this.player.tech_.vhs.bandwidth, 0, 'set bandwidth to 0'); |
There was a problem hiding this comment.
Kinda minor, but here and below, the test values being only 0 may run into issues if bandwidth is ever initialized in the future.
| @@ -511,6 +511,12 @@ class VhsHandler extends Component { | |||
| videojs.log.warn('Using hls options is deprecated. Use vhs instead.'); | |||
| } | |||
|
|
|||
| // if a tech level `initialBandwidth` option was passed | |||
There was a problem hiding this comment.
Probably worth documentating and mentioning that it takes precedence over VHS level bandwidth but not source level bandwidth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.