[RSDK-2782] Remove Periph GPIO from genericlinux boards #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng periph for gpio
viambot
added
the
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
penguinland
requested review from
a team and
randhid
and removed request for
a team
penguinland
commented
Jul 3, 2023
| cancelFunc: cancelFunc, | ||
|
|
||
| spis: map[string]*spiBus{}, | ||
| analogs: map[string]*wrappedAnalog{}, |
There was a problem hiding this comment.
The current diff makes this confusing because gofmt adjusted the whitespace. I've removed usePeriphGpio, pwms, and the comment just above pwms. The rest are unchanged.
randhid
reviewed
Jul 5, 2023
randhid
reviewed
Jul 5, 2023
randhid
requested changes
Jul 5, 2023
randhid
approved these changes
Jul 10, 2023
viambot
removed
the
safe to test
viambot
added
the
safe to test
Code Coverage
|
bazile-clyde
pushed a commit
to bazile-clyde/rdk
that referenced
this pull request
Jan 5, 2024
…#2603) The only board that was still using this was the nanopi, which has been relegated over to https://github.com/viam-labs/periph_board. I believe the only folks using that board were Peter L and Bee Ring, who already know about this change, and it has always been marked as experimental and not guaranteed to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only board that was still using this was the nanopi, which has been relegated over to https://github.com/viam-labs/periph_board. I believe the only folks using that board were @biotinker and Bee Ring, but I should do some more diligence on whether that's still true, because this is a breaking change.
I should thoroughly test this on some kind of Jetson, a BeagleBone AI-64, and maybe an Orange Pi 2 (for @natalieh235's work). Most of that will happen next week, but in the meantime the code is approximately ready for review.