APP-6324: Make ToggleButtons purely presentational #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micheal-parks
approved these changes
Oct 4, 2024
zaporter-work
approved these changes
Oct 4, 2024
| @@ -51,7 +51,6 @@ $: getButtonClasses = (option: string) => { | |||
| }; | |||
|
|
|||
| const handleClick = (value: string) => { | |||
| selected = value; | |||
There was a problem hiding this comment.
I wonder if we could put selected in a store and then when we handle the input event,we could just set $selected back to the original value (which IIRC would still trigger an update to this component even though the value is the same).
It might flash, but I think the transition would be quick.
There was a problem hiding this comment.
Also an option, but this behavior is weird and I think the component should be purely presentational instead of mixing stateful concerns.
|
@mrloureed is OOO - I will sync up with him about design.viam.com when he's back in office and keep this moving! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For teleop,
ToggleButtonsget used for page navigation. When the user flips fromEdit -> Monitor, the workspace gets saved. If there is an error while saving, we do not want to navigate toMonitor. Because theToggleButtonsset internal state, it appears as if toggling was successful. This makes theToggleButtonspurely presentational so that they only update when the parent changes theselectedprop.This will certainly be a breaking change somewhere when we bring it into App. I will do this PRIME upgrade myself and be sure to check all instances.
Change log
selectedstate fromToggleButtonsTODO