Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-6309: restrict text in Firefox in <RestrictedText> input #581

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

mcous
Copy link
Member

@mcous mcous commented Sep 19, 2024

Overview

Fun bug! In Firefox, the <RestrictedText> input does not restrict text:

2024-09-19 16 59 56

I traced this to a race-condition in out <Input> component due to its usage of bind. The on:input handler was setting the value to the restricted text, but then Svelte was coming in and setting the value back to an out-of-date value thanks to the bind. Very silly.

Change log

  • Move bind:value below on:input event in <Input> to ensure input event handlers take priority

Review requests

<RestrictedText> should restrict text in the playground and docs site

@mcous mcous changed the title APP-6309: move input binds down so event handlers take priority in Firefox APP-6309: restrict text in Firefox in <RestrictedText> input Sep 19, 2024
@mcous mcous merged commit d4d639a into main Sep 20, 2024
4 checks passed
@mcous mcous deleted the APP-6309/mcous/move-bind branch September 20, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants