Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Node.js version is always explicitly set in CI #208

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

mcous
Copy link
Member

@mcous mcous commented Mar 22, 2023

Overview

Little housekeeping PR to implement a couple GitHub Actions best practices:

  • Use actions/setup-node rather than relying on whatever version of Node.js happens to be installed by default on the runner
    • Also enables caching on npm packages, because it's easy
  • Lock non-GitHub actions to specific commits following GH's recommended security practices

Probably affected by #207 due to yaml formatting.

Test plan

Nothing special needed if CI stays green. Default Node.js version may require tweaking

@mcous mcous changed the title ci: ensure Node.js version is always explicitly set Ensure Node.js version is always explicitly set in CI Mar 22, 2023
@mcous mcous marked this pull request as ready for review March 22, 2023 16:54
Copy link
Member

@micheal-parks micheal-parks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also something that should be definitely replicated on APP and RDK

@mcous mcous merged commit 1296cbe into viamrobotics:main Mar 22, 2023
@mcous mcous deleted the ci-consitent-node-version branch March 22, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants