Add support for timeout on getting the next ssl record for a connection #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npmenard
force-pushed
the
RSDK-8984-add-ssl-timeout
branch
from
6db3cc2
to
952b50c
Compare
npmenard
force-pushed
the
RSDK-8984-add-ssl-timeout
branch
from
3ce1375
to
dc88562
Compare
gvaradarajan
requested changes
Oct 17, 2024
micro-rdk/src/esp32/dtls.rs
Outdated
| } | ||
| Err(e) => { | ||
| let _ = state.error.insert(e); | ||
| if state.error.as_ref().unwrap().kind() == std::io::ErrorKind::WouldBlock { |
| log::debug!("intermetidate timer expired"); | ||
| return 2; | ||
| } | ||
| if now > *self.fin.as_ref().unwrap() { |
There was a problem hiding this comment.
shouldn't we check fin before intermediate?
There was a problem hiding this comment.
nice catch that was really wrong :)
| @@ -426,24 +510,24 @@ impl SSLContext { | |||
| } | |||
| } | |||
|
|
|||
| pub struct SSLStream<S> { | |||
| pub(crate) struct SSLStream<S> { | |||
There was a problem hiding this comment.
this is holding a pointer and interacting with it in an unsafe way, is it ok that you don't have a drop implementation for de-allocating the memory behind the pointer?
There was a problem hiding this comment.
if you are talking about bio_ptr it should be dropped on line 519
npmenard
force-pushed
the
RSDK-8984-add-ssl-timeout
branch
from
9c57a47
to
44593cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.