[RSDK-8708] add coredump reader #309
Conversation
|
|
||
| const CORE_FRAGMENT_SIZE: usize = 3072; | ||
|
|
||
| impl DoCommand for Coredump { |
There was a problem hiding this comment.
I think it's worth having a comment outlining the three commands that can be sent, their expected values, and the high-level expected behavior
| })?; | ||
|
|
||
| if first_bytes[7] != 0xFF { | ||
| len = usize::from_le_bytes(first_bytes[0..4].try_into().unwrap()); // safe because we would have read 4 bytes |
There was a problem hiding this comment.
just to make sure I understand: we only need to do this once because even if someone erases the coredump via DoCommand, a coredump can only be written in a situation that what prompt a restart and result in reconfiguration? Is this correct? Or is there a situation in which something can be written to the coredump and a restart does not occur (meaning this sensor's state won't be properly reset)?
There was a problem hiding this comment.
coredump is only written on panic/abort whether from rust or C. So during the lifetime of the program the coredump exists until we erase it
No description provided.