Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APP-6483: Support Public Unlisted Modules #558

Merged
merged 4 commits into from
Sep 30, 2024
Merged

APP-6483: Support Public Unlisted Modules #558

merged 4 commits into from
Sep 30, 2024

Conversation

michaellee1019
Copy link
Member

No description provided.

@github-actions github-actions bot added the safe to test committer is a member of this org label Sep 26, 2024
@michaellee1019 michaellee1019 marked this pull request as ready for review September 30, 2024 13:45
@michaellee1019 michaellee1019 changed the title APP-6483: Support Unlisted Public Modules APP-6483: Support Public Unlisted Modules Sep 30, 2024
piokasar
piokasar approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@piokasar piokasar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@michaellee1019 michaellee1019 added the ready-for-protos add this when you want protos to compile on every commit label Sep 30, 2024
@michaellee1019 michaellee1019 added bug Something isn't working and removed bug Something isn't working labels Sep 30, 2024
@michaellee1019 michaellee1019 merged commit 6264f2b into viamrobotics:main Sep 30, 2024
6 checks passed
@michaellee1019 michaellee1019 deleted the ml/unlisted-public-modules branch September 30, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piokasar piokasar piokasar approved these changes

Assignees
No one assigned
Labels
ready-for-protos add this when you want protos to compile on every commit safe to test committer is a member of this org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaellee1019 @piokasar