Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APP-5851: Add optional visibility field to CreateFragmentRequest #543

Merged
merged 2 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,476 changes: 1,246 additions & 1,230 deletions app/v1/app.pb.go

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions component/camera/v1/camera.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions component/gantry/v1/gantry.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions component/gripper/v1/gripper.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions component/movementsensor/v1/movementsensor.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions component/posetracker/v1/pose_tracker.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions component/powersensor/v1/powersensor.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions gen/js/app/v1/app_pb.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2357,6 +2357,11 @@ export class CreateFragmentRequest extends jspb.Message {
getOrganizationId(): string;
setOrganizationId(value: string): void;

hasVisibility(): boolean;
clearVisibility(): void;
getVisibility(): FragmentVisibilityMap[keyof FragmentVisibilityMap];
setVisibility(value: FragmentVisibilityMap[keyof FragmentVisibilityMap]): void;

serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): CreateFragmentRequest.AsObject;
static toObject(includeInstance: boolean, msg: CreateFragmentRequest): CreateFragmentRequest.AsObject;
Expand All @@ -2372,6 +2377,7 @@ export namespace CreateFragmentRequest {
name: string,
config?: google_protobuf_struct_pb.Struct.AsObject,
organizationId: string,
visibility: FragmentVisibilityMap[keyof FragmentVisibilityMap],
}
}

Expand Down
50 changes: 49 additions & 1 deletion gen/js/app/v1/app_pb.js
Original file line number Diff line number Diff line change
Expand Up @@ -20301,7 +20301,8 @@ proto.viam.app.v1.CreateFragmentRequest.toObject = function(includeInstance, msg
var f, obj = {
name: jspb.Message.getFieldWithDefault(msg, 1, ""),
config: (f = msg.getConfig()) && google_protobuf_struct_pb.Struct.toObject(includeInstance, f),
organizationId: jspb.Message.getFieldWithDefault(msg, 3, "")
organizationId: jspb.Message.getFieldWithDefault(msg, 3, ""),
visibility: jspb.Message.getFieldWithDefault(msg, 4, 0)
};

if (includeInstance) {
Expand Down Expand Up @@ -20351,6 +20352,10 @@ proto.viam.app.v1.CreateFragmentRequest.deserializeBinaryFromReader = function(m
var value = /** @type {string} */ (reader.readString());
msg.setOrganizationId(value);
break;
case 4:
var value = /** @type {!proto.viam.app.v1.FragmentVisibility} */ (reader.readEnum());
msg.setVisibility(value);
break;
default:
reader.skipField();
break;
Expand Down Expand Up @@ -20402,6 +20407,13 @@ proto.viam.app.v1.CreateFragmentRequest.serializeBinaryToWriter = function(messa
f
);
}
f = /** @type {!proto.viam.app.v1.FragmentVisibility} */ (jspb.Message.getField(message, 4));
if (f != null) {
writer.writeEnum(
4,
f
);
}
};


Expand Down Expand Up @@ -20478,6 +20490,42 @@ proto.viam.app.v1.CreateFragmentRequest.prototype.setOrganizationId = function(v
};


/**
* optional FragmentVisibility visibility = 4;
* @return {!proto.viam.app.v1.FragmentVisibility}
*/
proto.viam.app.v1.CreateFragmentRequest.prototype.getVisibility = function() {
return /** @type {!proto.viam.app.v1.FragmentVisibility} */ (jspb.Message.getFieldWithDefault(this, 4, 0));
};


/**
* @param {!proto.viam.app.v1.FragmentVisibility} value
* @return {!proto.viam.app.v1.CreateFragmentRequest} returns this
*/
proto.viam.app.v1.CreateFragmentRequest.prototype.setVisibility = function(value) {
return jspb.Message.setField(this, 4, value);
};


/**
* Clears the field making it undefined.
* @return {!proto.viam.app.v1.CreateFragmentRequest} returns this
*/
proto.viam.app.v1.CreateFragmentRequest.prototype.clearVisibility = function() {
return jspb.Message.setField(this, 4, undefined);
};


/**
* Returns whether this field is set.
* @return {boolean}
*/
proto.viam.app.v1.CreateFragmentRequest.prototype.hasVisibility = function() {
return jspb.Message.getField(this, 4) != null;
};





Expand Down
1 change: 1 addition & 0 deletions proto/viam/app/v1/app.proto
Original file line number Diff line number Diff line change
Expand Up @@ -763,6 +763,7 @@ message CreateFragmentRequest {
string name = 1;
google.protobuf.Struct config = 2;
string organization_id = 3;
optional FragmentVisibility visibility = 4;
}

message CreateFragmentResponse {
Expand Down
Loading
Loading