[hotfix] fix log file create failed caused by name too long

[zoltar9264]

Fix log file create failed caused by name too long by keeping only the last 255 characters , discuss in FLINK-31743 .

[zoltar9264]

Hi @Myasuka , can you help me review this pr ?

[Myasuka]

Thanks for the update, please take a look at my comments.
BTW, it seems many tests not running, @fredia did you ever enable to run CI tests on circle?

[fredia]

did you ever enable to run CI tests on circle?

Hi @Myasuka, I have not modified the configuration of circleCI. It seems that 32(23+9) tests have been executed, and the newst RocksDB have 39 tests, which test do you mean is not executed?

[Myasuka]

@fredia Thanks for the clarification, I thought you disable some tests to save the billing on circle before.

I think this code change is trivial, @zoltar9264 could you check why so many tests failed after refactoring.

[zoltar9264]

Sorry for the late reply @Myasuka , I check the change and find the problem: size_t is unsigned, and "path.length() - (file_name_length_limit - sizeof(suffix))" will never be negative.

I added type cast.

[Myasuka]

I think some broken tests are due to the changed gcc version. Same code would throw warnings with the latest GCC.
gcc:latest in https://github.com/ververica/frocksdb/blob/FRocksDB-6.20.3/.circleci/config.yml#L324 changed from gcc-12 to gcc-13 comparing to last successful CI.

[zoltar9264]

Thanks to @Myasuka for helping to locate this problem. If it is true, should we use a specific gcc version, or should we fix the warnings reported in the higher version of gcc?

[Myasuka]

Thanks to @Myasuka for helping to locate this problem. If it is true, should we use a specific gcc version, or should we fix the warnings reported in the higher version of gcc?

From my point of view, I think we can fix the gcc docker image to a fixed version to avoid unnecessary code changes.