Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand-errors blames incorrect conjunct #1220

Open
jaylorch opened this issue Jul 11, 2024 · 1 comment
Open

Expand-errors blames incorrect conjunct #1220

jaylorch opened this issue Jul 11, 2024 · 1 comment
Assignees

Comments

@jaylorch
Copy link
Collaborator

In the attached recording, the "expand errors" report blames two failing quantified conjuncts, below. But only the second one is a problem; there's nothing wrong with the first conjunct. And indeed if you restore the commented-out part of the proof at the end of kv::lemma_volatile_matches_durable_after_create, you find that fixing the second conjunct is sufficient to fix the verification.

          |   forall |k|
          |       new_volatile_index.contains_key(k) ==>
          |           let indexed_offset = new_volatile_index.spec_index(k).0.header_addr;
          |               new_durable_state.contains_key(indexed_offset) ✘
          |               |   new_durable_state.spec_index(indexed_offset) is Some 
          |               +---
          |               new_durable_state.spec_index(indexed_offset).0.key == k ✘
          |   forall |i|
          |       new_durable_state.contains_key(i) ==>
          |           new_volatile_index.contains_key(new_durable_state.spec_index(i).0.key) ✘
          |           |   new_volatile_index.spec_index(new_durable_state.spec_index(i).0.key) is Some 
          |           +---
          |           new_volatile_index.spec_index(new_durable_state.spec_index(i).0.key).0.header_addr == i ✘

2024-07-11-11-44-44.zip

@jaylorch jaylorch changed the title Expand errors blames incorrect conjunct Expand-errors blames incorrect conjunct Jul 11, 2024
@tjhance
Copy link
Collaborator

tjhance commented Jul 16, 2024

this may have been fixed by d56fd23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants