Fix: do not depend on navigator.onLine; code optimizations #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 25f1f66:
|
huozhi
approved these changes
Mar 2, 2021
pacocoursey
approved these changes
Mar 2, 2021
|
Released |
This was referenced Mar 9, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the code comments,
navigator.onLineisn't always reliable due to this bug. Instead of depending on it, we have to use another approach to always assume it's online (since the page loads, it's very likely to be online). And when we receive theofflineevent fromwindow, we set the internal state to offline.With this change, SWR will still try to revalidate even it's offline, if both requirements are meet:
It's an extremely rare case.
Also did some code optimizations (results in a smaller bundle with ncc) and updated tests.