Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable NEXT_PUBLIC_ env var support #12283

Merged
merged 4 commits into from
Apr 29, 2020
Merged

Enable NEXT_PUBLIC_ env var support #12283

merged 4 commits into from
Apr 29, 2020

Conversation

timneutkens
Copy link
Member

Last part needed for #11106. This enables inlining of NEXT_PUBLIC_ prefixed environment variables at build time.

@ijjk
Copy link
Member

ijjk commented Apr 28, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
buildDuration 12.6s 12.7s ⚠️ +59ms
nodeModulesSize 55.2 MB 55.2 MB -1 B
Page Load Tests Overall decrease ⚠️
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.23 2.142 -0.09
/ avg req/sec 1120.85 1167.33 ⚠️ +46.48
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.179 1.292 ⚠️ +0.11
/error-in-render avg req/sec 2120.05 1935.61 -184.44
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
main-HASH.js gzip 6.26 kB 6.26 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e8e1.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
main-HASH.module.js gzip 4.81 kB 4.81 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
index.html gzip 927 B 927 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
buildDuration 13.1s 13.4s ⚠️ +317ms
nodeModulesSize 55.2 MB 55.2 MB -1 B
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
main-HASH.js gzip 6.26 kB 6.26 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e8e1.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
main-HASH.module.js gzip 4.81 kB 4.81 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 595 kB 595 kB ✓
routerDirect.js 587 kB 587 kB ✓
withRouter.js 588 kB 588 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@ijjk
Copy link
Member

ijjk commented Apr 29, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
buildDuration 10.7s 10.9s ⚠️ +163ms
nodeModulesSize 55.2 MB 55.2 MB -1 B
Page Load Tests Overall decrease ⚠️
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.906 1.861 -0.04
/ avg req/sec 1311.67 1343.55 ⚠️ +31.88
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.122 1.163 ⚠️ +0.04
/error-in-render avg req/sec 2227.99 2149.2 -78.79
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
main-HASH.js gzip 6.26 kB 6.26 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e8e1.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
main-HASH.module.js gzip 4.81 kB 4.81 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
index.html gzip 927 B 927 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 925 B 925 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
buildDuration 11.3s 11.5s ⚠️ +204ms
nodeModulesSize 55.2 MB 55.2 MB -1 B
Client Bundles (main, webpack, commons)
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
main-HASH.js gzip 6.26 kB 6.26 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..e8e1.js gzip 10.3 kB 10.3 kB ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.a1..NSE.txt gzip 220 B 220 B ✓
framework.HASH.js gzip 39.2 kB 39.2 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
main-HASH.module.js gzip 4.81 kB 4.81 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.88 kB 6.88 kB ✓
framework.HA..dule.js gzip 39.2 kB 39.2 kB ✓
Overall change 51.7 kB 51.7 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_app.js gzip 1.23 kB 1.23 kB ✓
_error.js gzip 3.15 kB 3.15 kB ✓
hooks.js gzip 663 B 663 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 280 B 280 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 7.88 kB 7.88 kB ✓
Client Pages Modern
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_app.module.js gzip 598 B 598 B ✓
_error.module.js gzip 2.09 kB 2.09 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 279 B 279 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary timneutkens/next.js add/enable-env-support Change
_error.js 557 kB 557 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 557 kB 557 kB ✓
link.js 595 kB 595 kB ✓
routerDirect.js 587 kB 587 kB ✓
withRouter.js 588 kB 588 kB ✓
Overall change 2.89 MB 2.89 MB ✓

@timneutkens timneutkens merged commit 04c9197 into vercel:canary Apr 29, 2020
@timneutkens timneutkens deleted the add/enable-env-support branch April 29, 2020 09:22
rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@timneutkens @rokinsky
Enable NEXT_PUBLIC_ env var support (vercel#12283)
53d7643
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timneutkens @ijjk @Timer