Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@shopify/react-i18n has broken since v11 (babel bug) #29500

Closed
jasonwilliams opened this issue Sep 29, 2021 · 3 comments
Closed

@shopify/react-i18n has broken since v11 (babel bug) #29500

jasonwilliams opened this issue Sep 29, 2021 · 3 comments
Assignees
Labels
bug Issue was opened via the bug report template. please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity

Comments

@jasonwilliams
Copy link

jasonwilliams commented Sep 29, 2021

What version of Next.js are you using?

10.2.4-canary.2 and above

What version of Node.js are you using?

15.0.0

What browser are you using?

Chrome

What operating system are you using?

MacOS

How are you deploying your application?

Other

Describe the Bug

We use react-i18n along with Next. It works by using Babel to compile all the translations during the build step. I tried using v11 of Next and translations did not work, i was getting errors or missing translations.

I managed to bisect the versions of Next down to 10.2.4-canary.2 being the issue. Looking at the releases notes I'm assuming the new babel mode has broken it somehow.

The error is:

error: Error: Missing translation for key: X in locale: en

Expected Behavior

Translations work on our NextJS site

To Reproduce

Working

Failing

  • (assuming you've ran the above)
  • in package.json change next to version 10.2.4-canary.2
  • npm i -f
  • npm run dev
  • navigate to http://localhost:3002/items/2
  • You should see a blank page and an error in the console

CC @samrmur

Possibly related to: #26539

@jasonwilliams jasonwilliams added the bug Issue was opened via the bug report template. label Sep 29, 2021
@jasonwilliams jasonwilliams changed the title @shopify/react-i18n has broken since 10.2.4-canary.2 (babel bug) @shopify/react-i18n has broken since v11 (babel bug) Sep 29, 2021
@jankaifer jankaifer self-assigned this Dec 1, 2022
@jankaifer jankaifer added the please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity label Dec 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Please verify that your issue can be recreated with next@canary.

Why was this issue marked with the please verify canary label?

We noticed the provided reproduction was using an older version of Next.js, instead of canary.

The canary version of Next.js ships daily and includes all features and fixes that have not been released to the stable version yet. You can think of canary as a public beta. Some issues may already be fixed in the canary version, so please verify that your issue reproduces by running npm install next@canary and test it in your project, using your reproduction steps.

If the issue does not reproduce with the canary version, then it has already been fixed and this issue can be closed.

How can I quickly verify if my issue has been fixed in canary?

The safest way is to install next@canary in your project and test it, but you can also search through closed Next.js issues for duplicates or check the Next.js releases.

My issue has been open for a long time, why do I need to verify canary now?

Next.js does not backport bug fixes to older versions of Next.js. Instead, we are trying to introduce only a minimal amount of breaking changes between major releases.

What happens if I don't verify against the canary version of Next.js?

An issue with the please verify canary that receives no meaningful activity (e.g. new comments that acknowledge verification against canary) will be automatically closed and locked after 30 days.

If your issue has not been resolved in that time and it has been closed/locked, please open a new issue, with the required reproduction, using next@canary.

I did not open this issue, but it is relevant to me, what can I do to help?

Anyone experiencing the same issue is welcome to provide a minimal reproduction following the above steps. Furthermore, you can upvote the issue using the 👍 reaction on the topmost comment (please do not comment "I have the same issue" without repro steps). Then, we can sort issues by votes to prioritize.

I think my reproduction is good enough, why aren't you looking into it quicker?

We look into every Next.js issue and constantly monitor open issues for new comments.

However, sometimes we might miss one or two due to the popularity/high traffic of the repository. We apologize, and kindly ask you to refrain from tagging core maintainers, as that will usually not result in increased priority.

Upvoting issues to show your interest will help us prioritize and address them as quickly as possible. That said, every issue is important to us, and if an issue gets closed by accident, we encourage you to open a new one linking to the old issue and we will look into it.

Useful Resources

@balazsorban44
Copy link
Member

This issue has been automatically closed because it wasn't verified against next@canary. If you think it was closed by accident, please leave a comment. If you are running into a similar issue, please open a new issue with a reproduction. Thank you.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template. please verify canary The issue should be verified against next@canary. It will be closed after 30 days of inactivity
Projects
None yet
Development

No branches or pull requests

3 participants