Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report filename of failing test #2889

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Report filename of failing test #2889

merged 1 commit into from
Feb 15, 2023

Conversation

ChristopherDavisUCI
Copy link
Contributor

In another PR, a change was causing the test_render_examples_to_chart test to fail, but I had a hard time locating which specific example was failing. This PR is an attempt to report the filename.

I tested this PR by temporarily adding an error to one of the example files (I used :ON rather than :O for an encoding type shorthand). This is what was reported to me by VS Code:

Screenshot 2023-02-15 at 9 48 11 AM

@mattijn mattijn merged commit 2ec93e5 into vega:master Feb 15, 2023
@mattijn
Copy link
Contributor

mattijn commented Feb 15, 2023

Thanks @ChristopherDavisUCI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants