Avoid confusing Python by returning generic objects for magic attributes. #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #2402 , we recently came up against an issue whereby Altair charts could not be deep-copied. The issue is that in three locations a
__getattr__method is implemented in such a way that it returns a object for any named attribute. This is usually helpful, but it sometimes confuses Python when it coincides with a Python "magic" method/attribute (which are always of form__<name>__; and in this case in particular,__deepcopy__is looked up but then doesn't behave in the waycopy.deepcopyexpects.This patch causes Altair to avoid returning generic objects as attributes for Python magic names, fixing this (and other similar) issue(s).
closes #2402