Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial implementation #1

Merged
merged 4 commits into from
Nov 24, 2020
Merged

Conversation

vasco-santos
Copy link
Owner

@vasco-santos vasco-santos commented Nov 11, 2020

This PR adds the initial implementation of the module.

The readme details extensively the motivation of the module, as well as the decisions made.

cc @acostalima

@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@15cfac0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             main        #1   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         1           
  Lines           ?        23           
  Branches        ?         0           
========================================
  Hits            ?        23           
  Misses          ?         0           
  Partials        ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15cfac0...765dda1. Read the comment docs.

Copy link

@acostalima acostalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor language suggestion, otherwise lgtm

README.md Outdated Show resolved Hide resolved
Co-authored-by: Jacob Heun <jacobheun@gmail.com>
@vasco-santos
Copy link
Owner Author

Thanks for having a look on this @jacobheun

@vasco-santos vasco-santos merged commit 2f9ae5e into main Nov 24, 2020
@vasco-santos vasco-santos deleted the feat/initial-implementation branch November 24, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants