Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Rendering inconsistencies with "quotation marks" (>) Admonitions in Live Preview #170

Closed
I-Pch opened this issue Feb 5, 2022 · 1 comment

Comments

@I-Pch
Copy link

I-Pch commented Feb 5, 2022

Hi there 😊 !

I wanted to create an Admonition using the "quotation marks" (>) syntax with no type and no title either 😊 !
I tried in Live Preview using this

> [!quote:]
> This is an admonition!

or this (with an added space after the colon)

> [!quote: ]
> This is an admonition!

... but it didn't seem to work (It works in Reading mode though) 😊 ...

After few more quick tests I discovered there are other inconsistencies too 😔

So, here are the tests I ran and their results 😇 :

Test 1 : Just the type

> [!quote]
> This is an admonition!

🟢 Live Preview : Works perfectly

Test 1 - Live Preview

🟢 Reading Mode: Works perfectly

Test 1 - Reading

Test 2 : Type + Title

> [!quote: I'm a title]
> This is an admonition!

🟠 Live Preview: The Admonition is fully rendered but the Title ("I'm a title") is missing (only the type is displayed)

Test 2 - Live Preview

🟢 Reading Mode: Works perfectly

Test 2 - Reading

Test 3: No Type + No title + Space (after the colon)

> [!quote: ]
> This is an admonition!

🟠 Live Preview: The Admonition is kind of rendered ...

Well, at least the content seems to be rendered and reacts directly (as it should in Live Preview) but the Admonition as a whole is not rendered (Sorry, it's a bit hard to explain 😅 )

Test 3 - Live Preview

🟢 Reading Mode: Works perfectly (This is what I was expecting to see in Live Preview 😊 )

Test 3 - Reading

Test 4: No Type + No title + No Space (after the colon)

> [!quote:]
> This is an admonition!

🟠 Live Preview: Like previously the content of the Admonition is directly rendered by the Live Preview, but the Admonition in its entirety is not rendered

Test 4 - Live Preview

🔴 Reading Mode: Doesn't work in Reading mode (it seems to be interpreted as a simple quote)

Test 4 - Reading

ℹ️ Test Environment

  • MacOS (Big Sur 11.6.2)
  • Obsidian 0.13.24 (No custom CSS/Community Theme)
  • Admonition 6.10.1

I used 3 different new notes so I could place them side-by-side to see the results in the different view mode 😊 .
The full markdown I wrote in Source Mode is this one :

**Test 1** : Just the type

> [!quote]
> This is an admonition!

**Test 2** : Type + Title

> [!quote: I'm a title]
> This is an admonition!

**Test 3** : No Type + No title + Space

> [!quote: ]
> This is an admonition!

**Test 4** : No Type + No title + No Space

> [!quote:]
> This is an admonition!

And I copied/pasted it in the 2 other notes. I then put one of the 2 in Live Preview and the last one in Reading Mode 😊

And here's is a "full view" of the result 😊

Admonition Tests

Sorry for the length 😅 ... I was trying to be as complete as I could hoping it would help you to perfect the Admonitions created using the > 😊

@I-Pch
Copy link
Author

I-Pch commented Feb 8, 2022

Thank you so very much @valentine195 🎉 🙌 !!!

Everything seems to be fixed 😁 and work perfectly 😁 !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant