fix: Content element will no longer be added if no content is provided (

close #201)
javalent · Mar 3, 2022 · 94d7a4b · 94d7a4b
1 parent aa4a075
commit 94d7a4b
Showing 1 changed file with 8 additions and 11 deletions.
diff --git a/src/main.ts b/src/main.ts
@@ -291,7 +291,7 @@ export default class ObsidianAdmonition extends Plugin {
                         : null),
                 collapse
             );
-            const contentEl = this.renderAdmonitionContent(
+            this.renderAdmonitionContent(
                 admonitionElement,
                 type,
                 content,
@@ -431,7 +431,7 @@ export default class ObsidianAdmonition extends Plugin {
                     .join("\n")
                     .replace(/^(>[ ]|\t|\s{4})/gm, "");
 
-                const contentEl = this.renderAdmonitionContent(
+                this.renderAdmonitionContent(
                     admonition,
                     type,
                     content,
@@ -844,16 +844,15 @@ export default class ObsidianAdmonition extends Plugin {
             ctx.addChild(markdownRenderChild);
         }
 
-        const contentEl = this.getAdmonitionContentElement(
-            type,
-            admonitionElement,
-            content
-        );
-        if (content && content.length) {
+        if (content && content?.trim().length) {
             /**
              * Render the content as markdown and append it to the admonition.
              */
-
+            const contentEl = this.getAdmonitionContentElement(
+                type,
+                admonitionElement,
+                content
+            );
             if (/^`{3,}mermaid/m.test(content)) {
                 const wasCollapsed = !admonitionElement.hasAttribute("open");
                 if (admonitionElement instanceof HTMLDetailsElement) {
@@ -912,8 +911,6 @@ export default class ObsidianAdmonition extends Plugin {
 
             this.addLinksToCache(links, sourcePath);
         }
-
-        return contentEl;
     }
 
     getAdmonitionContentElement(