Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the API for the percentile_approx dataframe method #527

Merged
merged 6 commits into from
Apr 16, 2020
Merged

Improve the API for the percentile_approx dataframe method #527

merged 6 commits into from
Apr 16, 2020

Conversation

JovanVeljanoski
Copy link
Member

Update the functionality of dataframe.percentile_approx:

  • Allow for a list of percentages to be passed, and get an array of results (percentiles) back. This is similar to the numpy.percentile functionality. For a list of expressions and a list of percentages the result should be a 2d numpy.array.
  • Tests describing the API and the expected behaviour
  • Review

@JovanVeljanoski JovanVeljanoski added this to the 3.0 milestone Dec 24, 2019
@JovanVeljanoski JovanVeljanoski changed the title test(core) Test for the new/proposed functionality of dataframe.perce… Improve the API for the percentile_approx dataframe method Jan 27, 2020
@maartenbreddels maartenbreddels merged commit e8cdd3a into master Apr 16, 2020
@maartenbreddels maartenbreddels deleted the improv_percentile_approx branch May 11, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority: medium
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JovanVeljanoski @maartenbreddels