Rename SKLearnPredictor to Predictor #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex.ml.sklearn.Predictor and update tests.
maartenbreddels
requested changes
Dec 24, 2019
packages/vaex-ml/vaex/ml/sklearn.py
Outdated
| 2 6.6 2.9 4.6 1.3 1 1.44276 | ||
| ''' | ||
|
|
||
| warnings.warn(message='''This class is deprecated and it wil will be removed in vaex-ml 0.8. |
There was a problem hiding this comment.
If you put this at the classlevel, it will always be executed (at import time). Put this in the constructor, and remove all the docstrings, and pass arguments to super.
packages/vaex-ml/vaex/ml/sklearn.py
Outdated
| from vaex.ml.state import serialize_pickle | ||
|
|
||
|
|
||
| @vaex.serialize.register | ||
| @generate.register | ||
| class SKLearnPredictor(state.HasState): | ||
| class Predictor(state.HasState): | ||
| '''This class wraps any scikit-learn estimator (a.k.a predictor) making it a vaex pipeline object. | ||
|
|
||
| By wrapping any scikit-learn estimators with this class, it becoes a vaex |
There was a problem hiding this comment.
Suggested change
| By wrapping any scikit-learn estimators with this class, it becoes a vaex | |
| By wrapping any scikit-learn estimators with this class, it becomes a vaex |
…ex.ml.sklearn.Predictor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames
vaex.ml.sklearn.SKLearnPredictortovaex.ml.sklearn.Predictorvaex.ml.sklearn.Predictor. Implementation is identical, only the class name is changed.vaex.ml.sklearn.SKLearnPredictorclass and update the docstring to mention that the class is being deprecated.vaex.ml.sklearn.Predictor