Fix: histogram sometimes does not obey selections #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
fix_histogram_selection
branch
from
344d4c0
to
75a4d9e
Compare
|
Party 🎉 |
|
Party!! 🎉 Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue could in partly due to
countsomething being buggy when handling arrow data that has missing values. Not sure tho, but there are tests implemented that cover these things in both sides for safety (asserting the histogram output and thecountoutput).Workaround:
If somebody is struggling with this issue, there is a simple workaround. Say column
xis arrow column with missing values. All you need to do is:and everything should work as expected.
Checklist: