Enable ForceAttemptHTTP2 on DoH client #72
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, DoH client can automatically enable http2 if server (very likely) supports it. It hopefully reduces latency, which is very crucial for DNS.
Previously, sendQuery() sent multiple requests simultaneously, and I observed frequent error logs like:
Because http/1.x doesn't intrinsically support multiplexing, the multiple waiting goroutines are not guaranteed to get responses in the order of requests. So, this is actually a bug fix :)