Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker.yaml to actions #64

Merged
merged 3 commits into from
Jul 25, 2020
Merged

Add docker.yaml to actions #64

merged 3 commits into from
Jul 25, 2020

Conversation

kallydev
Copy link
Contributor

@kallydev kallydev commented Jul 23, 2020

Resolved #45. This action will be triggered when the master branch commits a tag beginning with v.

Description

  1. Need to configure DOCKER_USERNAME and DOCKER_ PASSWORD in Secrets. If this commit needs to be merged into upstream v2ray in the future, please also keep this in mind.
  2. Now supports build Linux 386 / amd64 / armv7 / arm64.
  3. The build time is about 12 minutes. Each schema will only be built once, because the latest tag will hit the cache.

Demo

GitHub Actions

Docker Hub

@kallydev kallydev changed the title Add docker.yaml to actions (#45) Add docker.yaml to actions Jul 23, 2020
@kslr
Copy link
Contributor

kslr commented Jul 23, 2020

Cool, But we need to remove crazy-max/ghaction-docker-buildx

@kallydev
Copy link
Contributor Author

kallydev commented Jul 24, 2020

Cool, But we need to remove crazy-max/ghaction-docker-buildx

It's done. Demo link has not changed.

  • Buildx is an experimental feature, but there are no bugs yet.
  • Docker developers are developing Buidlx for Action.
  • If buildx releases update in the future, I will follow up in time.

@kslr kslr merged commit 0a19fb5 into v2fly:master Jul 25, 2020
@kslr
Copy link
Contributor

kslr commented Jul 25, 2020

I just found out that GitHub already has a docker package service, is this a good idea?

ref https://docs.github.com/en/packages/using-github-packages-with-your-projects-ecosystem/configuring-docker-for-use-with-github-packages

@kallydev
Copy link
Contributor Author

I just found out that GitHub already has a docker package service, is this a good idea?

ref https://docs.github.com/en/packages/using-github-packages-with-your-projects-ecosystem/configuring-docker-for-use-with-github-packages

Sure. I have done it, but we need to wait for problem Handle multi-arch Docker images on GitHub Package Registry to be resolved. If we only need Linux/amd64, I can modify sctipt tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Hub上的latest版本对应的还是上一个版本
2 participants