Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dotnet): Added .NET codegen support #38

Merged
merged 14 commits into from
Feb 11, 2024
Merged

Conversation

Mercurial
Copy link
Contributor

This PR adds .NET codegen support and csharp project file

@Mercurial Mercurial marked this pull request as ready for review January 31, 2024 14:46
Copy link
Contributor

@domMayhew domMayhew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scarmuega
Copy link
Member

@Mercurial looks great!

The only issue is that we won't be committing the generated source code, only the .csproj file should be part of the PR.

.bumpversion.toml Outdated Show resolved Hide resolved
@Mercurial
Copy link
Contributor Author

@Mercurial looks great!

The only issue is that we won't be committing the generated source code, only the .csproj file should be part of the PR.

Oh that's even better I didn't notice that change too, sorry about that will update and request review

@scarmuega scarmuega merged commit aaf70f2 into main Feb 11, 2024
@scarmuega scarmuega deleted the feat/dotnet-codegen branch February 11, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants