Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Docker Improvements #986

Closed
3 tasks done
ohsh6o opened this issue Jul 2, 2021 · 0 comments
Closed
3 tasks done

Minor Docker Improvements #986

ohsh6o opened this issue Jul 2, 2021 · 0 comments

Comments

@ohsh6o
Copy link
Contributor

ohsh6o commented Jul 2, 2021

User Story:

As an OSCAL developer, in order to make using the provided Docker container more usable with docker or docker-compose, I would like some improvements in dependency management, controlling their versions, and prestaging environment variables.

Goals:

This is a follow-up from some other issue discovered after #984. These are minor improvements, but seem worthwhile for NIST and community use.

  • When running with Docker, the ARG build argument is not passed along to an environment variable with ENV, so we must continuously express things like docker run -e SAXON_VERSION=9.9.0-1 -v $(pwd):/oscal oscal -x -c "./oscal/build/ci-cd/copy-and-convert-content.sh -o ./oscal -a . -c ./src/config -w . --resolve-profiles" even though that is built into the container before runtime and can be added at build time to match the Dockerfile.
  • The Dockerfile and docker-compose.yml file supply similar but different Saxon 9.x minor versions. This makes maintenance tedious and you have to Ctrl+F replace more files carefully if there is different behavior between docker and docker-compose when Saxon versions exhibit different behavior.
  • Dockerfile was not specifying the same npm install behavior as Github Actions, leading to many repeat validation command errors for JSON content that are hard to sift through.

Dependencies:

None

Acceptance Criteria

  • All OSCAL website and readme documentation affected by the changes in this issue have been updated. Changes to the OSCAL website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants