Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version behavior is inconsistent #524

Closed
nthnca opened this issue Sep 5, 2016 · 4 comments
Closed

Version behavior is inconsistent #524

nthnca opened this issue Sep 5, 2016 · 4 comments
Labels
area/v2 relates to / is being considered for v2 help wanted please help if you can! kind/feature describes a code enhancement / feature request status/confirmed confirmed to be valid, but work has yet to start

Comments

@nthnca
Copy link
Contributor

nthnca commented Sep 5, 2016

In #248 there was a change made so if a user empties the app.Version then the version is not printed as part of the help output.

This has left the -v, --version flags though which then creates the somewhat strange output of "app version" with no version number.

I would really prefer that the Version string is not initialized at all in cli.NewApp and then if the app.Version string is empty set HideVersion = true
@jszwedko
Copy link
Contributor

jszwedko commented Sep 9, 2016

I agree, thank you for bringing this up (I somehow missed this fact being pointed out in the comments in #248).

@jszwedko jszwedko added the kind/bug describes or fixes a bug label Sep 9, 2016
@nthnca nthnca mentioned this issue Sep 17, 2016
Closed
@asahasrabuddhe asahasrabuddhe self-assigned this Aug 5, 2019
@coilysiren coilysiren added the status/claimed someone has claimed this issue label Aug 29, 2019
@coilysiren
Copy link
Member

Un-assigning this since >1 month has passed without any movement

Anyone else is now free to work on this!

@coilysiren coilysiren added help wanted please help if you can! status/confirmed confirmed to be valid, but work has yet to start kind/feature describes a code enhancement / feature request area/v2 relates to / is being considered for v2 and removed status/claimed someone has claimed this issue kind/bug describes or fixes a bug labels Nov 27, 2019
This was referenced Nov 28, 2019
Merged
Merged
@stale
Copy link

stale bot commented Feb 25, 2020

This issue or PR has been automatically marked as stale because it has not had recent activity. Please add a comment bumping this if you're still interested in it's resolution! Thanks for your help, please let us know if you need anything else.

@stale stale bot added the status/stale stale due to the age of it's last update label Feb 25, 2020
@coilysiren
Copy link
Member

Resolved via #954 and #955

@meatballhat meatballhat removed the status/stale stale due to the age of it's last update label Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/v2 relates to / is being considered for v2 help wanted please help if you can! kind/feature describes a code enhancement / feature request status/confirmed confirmed to be valid, but work has yet to start
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide version if set to empty string
5 participants
@meatballhat @jszwedko @coilysiren @nthnca @asahasrabuddhe