You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Are you running the latest v2 release? The list of releases is here.
Did you check the manual for your release? The v2 manual is here
Did you perform a search about this problem? Here's the Github guide about searching.
Dependency Management
My project is using go modules.
Describe the bug
I've noticed a some issues / inconsistencies, while implementing #1409. I'm creating this issue just to make it clear what they are.
It appears Destination fields were added to the IntSliceFlag, Int64SliceFlag, and Float64SliceFlag structs, without actually implementing the necessary behavior
The StringSliceFlag.Value (default value) field may be modified by values passed in by environment variables
It doesn't seem like a problem, but the Value field seems like it should never be modified (e.g. don't initialise it if it's nil / use a local variable instead)
Past issues/PRs that may be relevant: #1235, #981, #1178
Currently open issues that may be relevant: #1224, #1143
To reproduce
N/A, but take a look at #1409, particularly the existing test I modified (for the second issue)
Observed behavior
See above
Expected behavior
The value / destination support of IntSliceFlag etc should be equivalent to StringSliceFlag. That said, there's a bit of a question around handling the (set) empty string env var case, however. See the note on my PR.
My urfave/cli version is
v2.8.1
Checklist
Dependency Management
Describe the bug
I've noticed a some issues / inconsistencies, while implementing #1409. I'm creating this issue just to make it clear what they are.
Destination
fields were added to theIntSliceFlag
,Int64SliceFlag
, andFloat64SliceFlag
structs, without actually implementing the necessary behaviorStringSliceFlag.Value
(default value) field may be modified by values passed in by environment variablesValue
field seems like it should never be modified (e.g. don't initialise it if it's nil / use a local variable instead)Past issues/PRs that may be relevant: #1235, #981, #1178
Currently open issues that may be relevant: #1224, #1143
To reproduce
N/A, but take a look at #1409, particularly the existing test I modified (for the second issue)
Observed behavior
See above
Expected behavior
The value / destination support of
IntSliceFlag
etc should be equivalent toStringSliceFlag
. That said, there's a bit of a question around handling the (set) empty string env var case, however. See the note on my PR.Run
go version
and paste its output hereRun
go env
and paste its output hereThe text was updated successfully, but these errors were encountered: