-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 feature: Add Destination for StringSliceFlag #1075
Comments
I think this might be a valuable addition :) |
See also => #603 🙂 |
Not really searched for that, right? Till yesterday that issue have been even open and have been closed for being a duplicate of this issue here... https://github.com/urfave/cli/issues?q=is%3Aissue+StringSliceFlag+Destination+is%3Aclosed |
@tboerger sorry you're having a hard time with the duplication thing! Is there something specific that you want here? |
@tboerger Sorry, obviously I didn't search very hard when I raised this. Agree mine should've been closed and yours left open. Happy for either issue to be used as long as it results in the feature being implemented. |
@lynncyrin I have some free tech time at work tomorrow so I can look into implementing this |
It's more about the communication than marking something duplicate. The initial issue has been marked as claimed, which sounds like somebody would work on that, after some time nothing happened and I actively asked if I can help somehow as this lib is massively used in projects I'm involved and I haven't received any response. Just with the closing as duplicate comment I have seen that the claimed label have been removed. I would just expect a tiny comment if somebody offers help. They issue is already nearly three years old. |
@tboerger I see what you mean. Well I'll be looking to raise a PR to add this functionality sometime tomorrow, unless you'd like to do so yourself. I also notice there are a few more flags missing the |
Go ahead, I would be happy to help testing. |
Got it 👍 it wasn't previously clear to me that there's so much social complexity here 🙏 @davidsbond I just assigned this to you 👍 |
@lynncyrin @tboerger I think my PR is ready for review. Appears to work in my testing |
This should go out in version |
Checklist
What problem does this solve?
Destination
values on flags so we can have our flag values strongly typed rather than stringly typed (i.e calling c.String("flag") etc.). I noticed that theStringSliceFlag
does not have aDestination
field like other flags doSolution description
Destination
field toStringSliceFlag
that works the same as all otherDestination
flag fields do.The text was updated successfully, but these errors were encountered: