Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deprecated import statements #65

Merged
merged 3 commits into from
Aug 25, 2023
Merged

update deprecated import statements #65

merged 3 commits into from
Aug 25, 2023

Conversation

vtnate
Copy link
Collaborator

@vtnate vtnate commented Aug 25, 2023 •
edited
Loading

  • Replace pkg_resources with importlib.metadata
  • Import from typing instead of typing.io

While running tests locally on the GMT, I noticed a deprecation warning originating from modelica-builder. The deprecation notification is here with a link to the current documentation here. This comment makes it appear that the deprecation is at least 3 years old.

FWIW, ANTLR is also giving deprecation warnings regarding typing.io which will be removed in Python 3.12 (import directly from typing instead). We should consider upgrading from our current antlr 4.8 to the newest antlr 4.13. Looks like 4.10 had significant changes.

I fixed the one instance in this repo where we imported from typing.io, but we could also do it the way Ted did it.

@vtnate vtnate added the dependencies Pull requests that update a dependency file label Aug 25, 2023
@vtnate vtnate requested a review from nllong August 25, 2023 17:05
@vtnate vtnate self-assigned this Aug 25, 2023
@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5978549664

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 88.889%
Changes Missing Coverage Covered Lines Changed/Added Lines %
modelica_builder/init.py 3 4 75.0%
Files with Coverage Reduction New Missed Lines %
modelica_builder/init.py 1 77.78%
Totals Coverage Status
Change from base Build 5869180877: 0.0%
Covered Lines: 648
Relevant Lines: 729
💛 - Coveralls

@nllong nllong merged commit 8e86994 into develop Aug 25, 2023
2 checks passed
@nllong nllong deleted the remove-deprecated-pkg_resources branch August 25, 2023 17:32
@vtnate vtnate changed the title update deprecated call to pkg_resources update deprecated import statements Oct 3, 2023
nllong added a commit that referenced this pull request Oct 5, 2023
@nllong @dependabot @vtnate
Release 0.4.0 (#71)
05b1efb 
* add get method for a component

* Update README.rst

* add extends argument manipulation

* do not save temp file

* build(deps): bump pygments from 2.12.0 to 2.15.0

Bumps [pygments](https://github.com/pygments/pygments) from 2.12.0 to 2.15.0.
- [Release notes](https://github.com/pygments/pygments/releases)
- [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES)
- [Commits](pygments/pygments@2.12.0...2.15.0)

---
updated-dependencies:
- dependency-name: pygments
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update test_model.py

* add method for getting and setting parameters

* cleanup

* add dictionary

* fix end of dict fileg

* Bump version and update test dependencies (#62)

* bump version and update test depends

* prepare the last of the release items

* update _source on save_as (#64)

* update deprecated call to pkg_resources (#65)

* update deprecated call to pkg_resources

* argh, pre-commit

* import from `typing` instead of `typing.io`

* Add poetry and remove tox (#67)

* remove tox and add poetry

* run pre-commit

* add benchmark package

* add building of doc in test

* update dependendencies

* precommit

* Move Modelica methods over from GMT (#68)

* remove tox and add poetry

* run pre-commit

* add benchmark package

* add building of doc in test

* update dependendencies

* precommit

* move modelica methods from gmt

---------

Co-authored-by: Nathan Moore <nathan.moore@nrel.gov>

* Update antlr4 and use a non-deprecated docker base image (#66)

* update antlr4 to 4.13.0

* bump to antlrv4.13.1

* `poetry update` to bump dependency versions

* remove redundant CI run

* use os & python version matrix in github ci

* eek, found an obvious miss of another antlr version mention

* another `poetry update` to pick up the new antlr runtime version

* use new base image in dockerfile

* rebuild docker container

* remove Windows from CI, it's too soon for that

* update changelog (#70)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nathan Moore <nathan.moore@nrel.gov>
nllong added a commit that referenced this pull request Jan 4, 2024
@nllong @dependabot @vtnate
Release 0.5.0 (#78)
3a432d1 
* add get method for a component

* Update README.rst

* add extends argument manipulation

* do not save temp file

* build(deps): bump pygments from 2.12.0 to 2.15.0

Bumps [pygments](https://github.com/pygments/pygments) from 2.12.0 to 2.15.0.
- [Release notes](https://github.com/pygments/pygments/releases)
- [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES)
- [Commits](pygments/pygments@2.12.0...2.15.0)

---
updated-dependencies:
- dependency-name: pygments
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update test_model.py

* add method for getting and setting parameters

* cleanup

* add dictionary

* fix end of dict fileg

* Bump version and update test dependencies (#62)

* bump version and update test depends

* prepare the last of the release items

* update _source on save_as (#64)

* update deprecated call to pkg_resources (#65)

* update deprecated call to pkg_resources

* argh, pre-commit

* import from `typing` instead of `typing.io`

* Add poetry and remove tox (#67)

* remove tox and add poetry

* run pre-commit

* add benchmark package

* add building of doc in test

* update dependendencies

* precommit

* Move Modelica methods over from GMT (#68)

* remove tox and add poetry

* run pre-commit

* add benchmark package

* add building of doc in test

* update dependendencies

* precommit

* move modelica methods from gmt

---------

Co-authored-by: Nathan Moore <nathan.moore@nrel.gov>

* Update antlr4 and use a non-deprecated docker base image (#66)

* update antlr4 to 4.13.0

* bump to antlrv4.13.1

* `poetry update` to bump dependency versions

* remove redundant CI run

* use os & python version matrix in github ci

* eek, found an obvious miss of another antlr version mention

* another `poetry update` to pick up the new antlr runtime version

* use new base image in dockerfile

* rebuild docker container

* remove Windows from CI, it's too soon for that

* update changelog (#70)

* Support py312 (#73)

* add support for python 3.12

* update dependencies

* update pre-commit hooks with `pre-commit autoupdate`

* Add method to scale loads in an MOS file (#74)

* scale loads in mos file

* cleanup doc

* remove print

* more documentation

* bump version of antrl to 4.13.1 (#75)

* add .mpignore to skip loading files in ModelicaProject (#77)

* Upgrade to MBLv10 (#72)

* use mblv10 when templating package.mo

* add parameter for mbl_version in PackageParser

* template mbl_version in top-level package.mot

* test to confirm mbl_version gets templatized correctly in PackageParser

* include python 3.12 in ci, which was accidentally forgotten

* check for mbl_version when loading templates

* Update copyright dates (#80)

* update license dates

* update copyright holder

* update language in license

* Prepare for v0.5.0 release (#79)

* bump to v0.5.0, update changelog

* Update CHANGELOG.rst

---------

Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
Co-authored-by: Nicholas Long <nicholas.long@nrel.gov>

* update dependencies

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Nathan Moore <nathan.moore@nrel.gov>
vtnate added a commit that referenced this pull request Jan 5, 2024
@vtnate @nllong @dependabot
Prep version 0.5.1 (#83)
393166c 
* add get method for a component

* Update README.rst

* add extends argument manipulation

* do not save temp file

* build(deps): bump pygments from 2.12.0 to 2.15.0

Bumps [pygments](https://github.com/pygments/pygments) from 2.12.0 to 2.15.0.
- [Release notes](https://github.com/pygments/pygments/releases)
- [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES)
- [Commits](pygments/pygments@2.12.0...2.15.0)

---
updated-dependencies:
- dependency-name: pygments
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update test_model.py

* add method for getting and setting parameters

* cleanup

* add dictionary

* fix end of dict fileg

* Bump version and update test dependencies (#62)

* bump version and update test depends

* prepare the last of the release items

* update _source on save_as (#64)

* update deprecated call to pkg_resources (#65)

* update deprecated call to pkg_resources

* argh, pre-commit

* import from `typing` instead of `typing.io`

* Add poetry and remove tox (#67)

* remove tox and add poetry

* run pre-commit

* add benchmark package

* add building of doc in test

* update dependendencies

* precommit

* Move Modelica methods over from GMT (#68)

* remove tox and add poetry

* run pre-commit

* add benchmark package

* add building of doc in test

* update dependendencies

* precommit

* move modelica methods from gmt

---------

Co-authored-by: Nathan Moore <nathan.moore@nrel.gov>

* Update antlr4 and use a non-deprecated docker base image (#66)

* update antlr4 to 4.13.0

* bump to antlrv4.13.1

* `poetry update` to bump dependency versions

* remove redundant CI run

* use os & python version matrix in github ci

* eek, found an obvious miss of another antlr version mention

* another `poetry update` to pick up the new antlr runtime version

* use new base image in dockerfile

* rebuild docker container

* remove Windows from CI, it's too soon for that

* update changelog (#70)

* Support py312 (#73)

* add support for python 3.12

* update dependencies

* update pre-commit hooks with `pre-commit autoupdate`

* Add method to scale loads in an MOS file (#74)

* scale loads in mos file

* cleanup doc

* remove print

* more documentation

* bump version of antrl to 4.13.1 (#75)

* add .mpignore to skip loading files in ModelicaProject (#77)

* Upgrade to MBLv10 (#72)

* use mblv10 when templating package.mo

* add parameter for mbl_version in PackageParser

* template mbl_version in top-level package.mot

* test to confirm mbl_version gets templatized correctly in PackageParser

* include python 3.12 in ci, which was accidentally forgotten

* check for mbl_version when loading templates

* Update copyright dates (#80)

* update license dates

* update copyright holder

* update language in license

* Prepare for v0.5.0 release (#79)

* bump to v0.5.0, update changelog

* Update CHANGELOG.rst

---------

Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
Co-authored-by: Nicholas Long <nicholas.long@nrel.gov>

* update dependencies

* make if statement more constrained (#81)

* Create config file to automatically publish to pypi when a Github release is made (#82)

* automatic pypi release workflow config. needs pypi & github settings to work

* bump versions of actions used in the release workflow

* argh pre-commit

* changelog for 0.5.1

* bump to version 0.5.1

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Nicholas Long <nicholas.long@nrel.gov>
Co-authored-by: Nicholas Long <1907354+nllong@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nllong nllong nllong approved these changes

Assignees

@vtnate vtnate

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtnate @nllong