Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace moment with date-fns #103

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Replace moment with date-fns #103

merged 2 commits into from
Jul 23, 2020

Conversation

ivesdebruycker
Copy link
Contributor

See #84

scaredcat
scaredcat reviewed May 2, 2020
View reviewed changes
Copy link
Contributor

@scaredcat scaredcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good. A couple of pointers:

  1. Please replace moment in stories/index.js so that storybook can continue to work. You can test by running yarn storybook

  2. Please ensure linting passes (also done by travis). You can ignore the warnings

src/files/list-thumbnail.js Outdated Show resolved Hide resolved
src/files/table.js Outdated Show resolved Hide resolved
@scaredcat scaredcat requested a review from jlo-1 June 22, 2020 01:33
@jlo-1
Copy link
Contributor

jlo-1 commented Jul 23, 2020

Excellent, thanks for contributing 👍

@jlo-1 jlo-1 merged commit be9ba8c into uptick:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scaredcat scaredcat scaredcat left review comments

@jlo-1 jlo-1 Awaiting requested review from jlo-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivesdebruycker @jlo-1 @scaredcat