Add the possibility to configure the base URL of the GitHub API #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot 鉁嶏笍 All contributors have signed the CLA |
|
I have read the CLA Document and I hereby sign the CLA |
AnandChowdhary
approved these changes
Nov 15, 2020
|
馃帀 This PR is included in version 1.4.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a way of configuring the base URL of the API with which the frontend should communicate. The implementation is the result of the brainstorming in upptime/upptime#54 where @AnandChowdhary and I discussed ways on how to use
upptimewith private repositories. One option would be to create a lightweight proxy which provides the same API surface as the original GitHub API, but makes authorized calls against the actual GitHub production API. For signalling the frontend against which API it should communicate, the introduction of a new configuration was necessary.I tested it locally against a rudimentary proxy I just hacked together and it worked like a charm 馃檪