Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iteration bug, remove conversion to float. #37

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Conversation

nekhtiari
Copy link
Owner

This PR fixes the iteration bug and remove float conversion.

Copy link
Contributor

@chrieke chrieke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@nekhtiari nekhtiari merged commit 0e9227e into master Jan 11, 2022
@nekhtiari nekhtiari deleted the fix-rmse-bug branch January 11, 2022 15:49
@chrieke chrieke mentioned this pull request Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants