Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pyfftw and rasterio extra dependencies #24

Merged
merged 2 commits into from
Mar 29, 2021

Conversation

akx
Copy link
Contributor

@akx akx commented Feb 9, 2021

This will make the installation footprint of the package smaller by default.

  • pyFFTW not strictly required; it's just a faster FFT backend (used by Phasepack, hence by the FSIM metric).
  • rasterio is only needed for reading TIFFs in an... alternate way, it seems? I guess it has to do with some multi-channel TIFFs? Either way, it's not required for using the package as a library (which I'm doing, for instance).

This also expands the GHA workflow to:

  • test all three out of four of these configurations (no extras, speedups, speedups + rasterio).
  • test all the metrics

@akx akx marked this pull request as draft February 9, 2021 10:24
@akx akx marked this pull request as ready for review February 9, 2021 10:31
@akx akx force-pushed the dep-extras branch 2 times, most recently from e6226e7 to 5a4790a Compare February 9, 2021 10:38
Copy link
Owner

@nekhtiari nekhtiari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @markusuwe please have a look!

@nekhtiari nekhtiari merged commit 591b209 into nekhtiari:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants