Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating the linker shipped with Uno packages #13293

Open
Youssef1313 opened this issue Aug 17, 2023 · 2 comments
Open

Consider updating the linker shipped with Uno packages #13293

Youssef1313 opened this issue Aug 17, 2023 · 2 comments
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools

Comments

@Youssef1313
Copy link
Member

We ship the linker from https://github.com/unoplatform/uno/tree/master/src/SourceGenerators/Uno.UI.Tasks/external/linker

This hasn't been updated for long. So we lose any bug fixes done by dotnet/runtime, and also any potential performance improvements (e.g, dotnet/linker#3094).

@Youssef1313 Youssef1313 added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Aug 17, 2023
@jeromelaban
Copy link
Member

jeromelaban commented Aug 17, 2023

We actually should be removing the linker entirely, now that there's a nuget package we can use instead. https://nuget.info/packages/Microsoft.NET.ILLink.Tasks/8.0.100-1.23067.1. It's not clear if that package will keep being used, though, as it's not been updated in a while.

@Youssef1313
Copy link
Member Author

It's not clear if that package will keep being used, though, as it's not been updated in a while.

The last package update is 9 days ago. It's not showing as the last version on NuGet due to strange versioning:

image

So yes, if we can use this package it will be great so that we easily get the updates.

@MartinZikmund MartinZikmund added project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI area/performance 📈 Categorizes an issue or PR as relevant to performance and removed triage/untriaged Indicates an issue requires triaging or verification difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance 📈 Categorizes an issue or PR as relevant to performance difficulty/medium 🤔 Categorizes an issue for which the difficulty level is reachable with a good understanding of WinUI kind/enhancement New feature or request project/core-tools 🛠️ Categorizes an issue or PR as relevant to core and tools
Projects
None yet
Development

No branches or pull requests

3 participants