-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dsl: allow to specify a default value in $ and & operators #3984
dsl: allow to specify a default value in $ and & operators #3984
Conversation
Reporting the coverage to coverall failed. |
codecov-cli report following:
That's to say codecov invoke the Github Actions API, but Github Actions API has the rate limitation. To remove the rate limitation, you should configure a how to get a Codecov upload token: https://github.com/codecov/codecov-cli?tab=readme-ov-file#how-to-get-an-upload-token Another solution is to use old version of |
I found |
I updated it a few days ago. (in my recognition) |
Currently we are using the codecov CLI directly. Is it better to using |
Hmm, still failing. |
https://github.com/universal-ctags/ctags/actions/runs/8680720408/job/23960447081#step:18:22
I think it is strange that |
In my understanding, it will be always shown empty for security reasons when you updating the secrets. |
That's true. |
It looks fine with codecov/codecov-actions: #3986 |
$ and & return #f if a specified field is not found in a tag. With this change, you can make the operators return a value other than #f in the situation. You can write ($ field default-value) as a shorthand of (or ($ field) default-value) . Signed-off-by: Masatake YAMATO <yamato@redhat.com>
882226e
to
19bc9ad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3984 +/- ##
==========================================
+ Coverage 85.39% 85.40% +0.01%
==========================================
Files 235 235
Lines 56628 56636 +8
==========================================
+ Hits 48358 48371 +13
+ Misses 8270 8265 -5 ☔ View full report in Codecov by Sentry. |
The coverall comes back! Thank you. |
@AmaiKinono I expect the feature I added to readtags via this pull request can simplify readtags filter expressions in citre. You can expect this feature to be available if the version of readtags is greater or equal to 6.2.0. |
$ and & return #f if a specified field is not found in a tag. With this change, you can make the operators return a value other than #f in the situation.
You can write
as a shorthand of
.