Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove StorageProof in favor of using a single Proof directly #1803

Closed
benluelo opened this issue Apr 23, 2024 · 1 comment
Closed

Remove StorageProof in favor of using a single Proof directly #1803

benluelo opened this issue Apr 23, 2024 · 1 comment
Labels
A-lightclients Area: Light Clients C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@benluelo
Copy link
Contributor

We define StorageProof as a list of Proofs, however we only ever use one proof. We should remove the StorageProof type and use Proof everywhere instead.

ref: https://github.com/unionlabs/union/blob/main/uniond/proto/union/ibc/lightclients/ethereum/v1/ethereum.proto#L8-L10
@benluelo benluelo added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Apr 23, 2024
@benluelo benluelo added the A-lightclients Area: Light Clients label Sep 21, 2024
@benluelo
Copy link
Contributor Author

this was fixed in #1944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-lightclients Area: Light Clients C-enhancement Category: An issue proposing an enhancement or a PR with one. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benluelo