This repository has been archived by the owner on Aug 26, 2024. It is now read-only.
decouple parser from feature-loading/transform #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Niels Bantilan niels.bantilan@gmail.com
This PR decouples the runtime and type dependency between the feature loader/transformer and parser. Before this PR, the
Dataset.get_featuresmethod invokesfeature_loader -> parser -> feature_transformer. This was so that theparseris re-used to grab features from the raw feature data.This isn't great because it adds a level of complexity that isn't needed: basically the
predictorshould be able to handle inputs from bothparserandfeature_loader -> feature_transformer. This PR does this decoupling so that the end-user only has to think about predicting from:reader -> ... -> parser -> predictor: when callingmodel.predict(**reader_kwargs)feature_loader -> feature_transformer -> predictor: when callingmodel.predict(features=features)