Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mypy: fix errors, codecov UNKNOWN badge fix #171

Merged
merged 39 commits into from
Oct 20, 2022
Merged

Conversation

dilyabareeva
Copy link
Collaborator

@dilyabareeva dilyabareeva commented Oct 12, 2022

Implemented changes

  • fix most errors
  • small edits in CONTRIBUTING.MD
  • branched from mypy-static-type-checker

Minimum acceptance criteria

  • All errors fixed or intentionally rejected
  • All tests passed

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2022

Codecov Report

Merging #171 (eb07d66) into main (b77d586) will decrease coverage by 0.12%.
The diff coverage is 80.85%.

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   92.86%   92.74%   -0.13%     
==========================================
  Files          54       54              
  Lines        2649     2660      +11     
==========================================
+ Hits         2460     2467       +7     
- Misses        189      193       +4     
Impacted Files Coverage Δ
quantus/functions/explanation_func.py 89.07% <ø> (ø)
quantus/helpers/model/tf_model.py 94.11% <0.00%> (ø)
quantus/metrics/axiomatic/completeness.py 94.28% <ø> (ø)
quantus/metrics/axiomatic/input_invariance.py 100.00% <ø> (ø)
quantus/metrics/axiomatic/non_sensitivity.py 100.00% <ø> (ø)
quantus/metrics/complexity/complexity.py 100.00% <ø> (ø)
quantus/metrics/complexity/effective_complexity.py 100.00% <ø> (ø)
quantus/metrics/complexity/sparseness.py 100.00% <ø> (ø)
...s/metrics/faithfulness/faithfulness_correlation.py 95.83% <ø> (ø)
...ntus/metrics/faithfulness/faithfulness_estimate.py 97.95% <ø> (ø)
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@annahedstroem annahedstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for going over all the types!

@annahedstroem
Copy link
Member

Remaining is to resolve merge conflicts as seen ^^.
(@dkrako has cleaned up the custom_preprocess so most of the metric files are affected)

dilyabareeva and others added 11 commits October 18, 2022 17:07
# Conflicts:
#	quantus/functions/explanation_func.py
#	quantus/helpers/asserts.py
#	quantus/helpers/plotting.py
#	quantus/metrics/axiomatic/completeness.py
#	quantus/metrics/axiomatic/input_invariance.py
#	quantus/metrics/axiomatic/non_sensitivity.py
#	quantus/metrics/base.py
#	quantus/metrics/complexity/complexity.py
#	quantus/metrics/complexity/effective_complexity.py
#	quantus/metrics/complexity/sparseness.py
#	quantus/metrics/faithfulness/faithfulness_correlation.py
#	quantus/metrics/faithfulness/faithfulness_estimate.py
#	quantus/metrics/faithfulness/infidelity.py
#	quantus/metrics/faithfulness/irof.py
#	quantus/metrics/faithfulness/monotonicity.py
#	quantus/metrics/faithfulness/monotonicity_correlation.py
#	quantus/metrics/faithfulness/pixel_flipping.py
#	quantus/metrics/faithfulness/region_perturbation.py
#	quantus/metrics/faithfulness/road.py
#	quantus/metrics/faithfulness/selectivity.py
#	quantus/metrics/faithfulness/sensitivity_n.py
#	quantus/metrics/faithfulness/sufficiency.py
#	quantus/metrics/localisation/attribution_localisation.py
#	quantus/metrics/localisation/auc.py
#	quantus/metrics/localisation/focus.py
#	quantus/metrics/localisation/pointing_game.py
#	quantus/metrics/localisation/relevance_mass_accuracy.py
#	quantus/metrics/localisation/relevance_rank_accuracy.py
#	quantus/metrics/localisation/top_k_intersection.py
#	quantus/metrics/randomisation/model_parameter_randomisation.py
#	quantus/metrics/randomisation/random_logit.py
#	quantus/metrics/robustness/avg_sensitivity.py
#	quantus/metrics/robustness/consistency.py
#	quantus/metrics/robustness/continuity.py
#	quantus/metrics/robustness/local_lipschitz_estimate.py
#	quantus/metrics/robustness/max_sensitivity.py
Copy link
Member

@annahedstroem annahedstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, remaining fix is mypy in CI/CD

@annahedstroem annahedstroem mentioned this pull request Oct 19, 2022
@annahedstroem annahedstroem changed the title Mypy: fix errors Mypy: fix errors, codecov UNKNOWN badge fix Oct 19, 2022
@annahedstroem
Copy link
Member

Checked the remaining errors which are fixed or rejected (as non-important error or error is wrong).

@annahedstroem annahedstroem merged commit 43bc93a into main Oct 20, 2022
@annahedstroem annahedstroem deleted the mypy_fix_issues_ci_cd branch January 11, 2023 08:23
aaarrti pushed a commit that referenced this pull request Apr 9, 2023
…mypy_fix_issues_ci_cd

Mypy: fix errors, codecov UNKNOWN badge fix

Minimum acceptance criteria achieved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants