Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate vectorizing metric computation #299

Open
aaarrti opened this issue Oct 5, 2023 · 0 comments
Open

Investigate vectorizing metric computation #299

aaarrti opened this issue Oct 5, 2023 · 0 comments

Comments

@aaarrti
Copy link
Collaborator

aaarrti commented Oct 5, 2023 •
edited
Loading

Description of the problem

  • A lot of metrics do computations on a single instance.
  • They often could be computed in batches.

Description of a solution

Apply vectorization (or batch computations) for

  • Completeness
  • Complexity

Investigate which other metrics can be batched/vectorized.

Minimum acceptance criteria

  • Metric outputs did not change.

A typical instance-wise metric is currently implemented like this way:

return [self.evaluate_instance(x, a) for x, a in zip(x_batch, a_batch)]

we want to get rid of these for-loops.
@aaarrti aaarrti mentioned this issue Oct 5, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaarrti