Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is internet connection necessary? #757

Closed
ckf42 opened this issue Jun 16, 2022 · 2 comments
Closed

Is internet connection necessary? #757

ckf42 opened this issue Jun 16, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@ckf42
Copy link

ckf42 commented Jun 16, 2022

Hi. I am on a Windows machine, so I am not sure if this also happens to the MacOS build.
It appears that internet connection is required for the software to boot up.

Steps to reproduce:

  1. Install while having a firewall that blocks all connections by default (installing offline should also have the same effect)
  2. Start graphest

graphest will spawn ~3 processes but no gui window is shown. The problem cannot be reproduced if internet connection is allowed once. Afterward everything just seems to work, even after an offline reinstall.

It also appears that graphest will keep sending network requests despite there is no apparent need to do so.

Are there any features that require internet connections?

@unageek
Copy link
Owner

unageek commented Jun 18, 2022

Hi! Thank you so much for the detailed report. I can reproduce the issue.

Internet connection is required by the following codes:

graphest/src/main/main.ts

Lines 214 to 216 in 8dd6155

await installExtension([REACT_DEVELOPER_TOOLS, REDUX_DEVTOOLS], {
loadExtensionOptions: { allowFileAccess: true },
});

autoUpdater.checkForUpdatesAndNotify();

Both of them raise an exception when there is no internet connection. I will fix the issue in the next release.

@unageek unageek added the bug Something isn't working label Jun 19, 2022
@unageek
Copy link
Owner

unageek commented Jun 19, 2022

Fixed in 3b39609.

@unageek unageek closed this as completed Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants