Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve the auto tsconfig logic for dot dumi dir #1903

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

PeachScript
Copy link
Member

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature
  • bug 修复 / Fix bug
  • 样式优化 / Style optimization
  • 代码风格优化 / Code style optimization
  • 性能优化 / Performance optimization
  • 构建优化 / Build optimization
  • 网站、文档、Demo 改进 / Website, documentation, demo improvements
  • 重构代码或样式 / Refactor code or style
  • 测试相关 / Test related
  • 其他 / Other

🔗 相关 Issue / Related Issue

#1902

💡 需求背景和解决方案 / Background or solution

优化对 .dumi 目录的自动 tsconfig.json 更改逻辑的实现,从往根目录 tsconfig.json 添加 include 值改为在子目录创建 tsconfig.json,后者是对原项目侵扰更少,且复杂度更低的方案,同样可以为 .dumi 目录下的文件启用类型识别

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English Improve the auto tsconfig logic for dot dumi dir
🇨🇳 Chinese 改进为 .dumi 生成自动 tsconfig 的逻辑

@vercel
Copy link

vercel bot commented Sep 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dumi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 17, 2023 11:59am

@crazyair
Copy link
Contributor

https://github.com/ant-design/ant-design/pull/44834/files 这个白弄了,哈哈哈

@PeachScript
Copy link
Member Author

https://github.com/ant-design/ant-design/pull/44834/files 这个白弄了,哈哈哈

setup 还是必要的,缺临时文件也会找不到类型 👀

但还得配合 @@/* 的别名配置才能工作,我会更新下这个 PR 解决这个问题:ant-design/ant-design#44886

@PeachScript PeachScript merged commit e2074af into master Sep 17, 2023
10 checks passed
@PeachScript PeachScript deleted the feature/better-dot-dumi-tsconfig branch September 17, 2023 12:36
@crazyair
Copy link
Contributor

monorepo 项目好像兼容有问题,没有自动生成 tsconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants