Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in BaseModel._forward_once #9442

Closed
1 of 2 tasks
fcakyon opened this issue Sep 16, 2022 · 1 comment · Fixed by #9443
Closed
1 of 2 tasks

Typo in BaseModel._forward_once #9442

fcakyon opened this issue Sep 16, 2022 · 1 comment · Fixed by #9443
Labels
bug Something isn't working

Comments

@fcakyon
Copy link
Member

fcakyon commented Sep 16, 2022

Search before asking

  • I have searched the YOLOv5 issues and found no similar bug report.

YOLOv5 Component

Detection

Bug

save_dir is assigned with bool value which raises an error (it should be Path)

feature_visualization(x, m.type, m.i, save_dir=visualize)

Environment

YOLOv5 6.2 (commit: 03f2ca8)
Ubuntu 18.04
Python 3.8

Minimal Reproducible Example

model = torch.hub.load('ultralytics/yolov5', 'yolov5s')

result = model(Image.open('data/images/bus.jpg'), size=1344, augment=False, profile=True)

Additional

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@fcakyon fcakyon added the bug Something isn't working label Sep 16, 2022
@glenn-jocher
Copy link
Member

@fcakyon good news 😃! Your original issue may now be fixed ✅ in PR #9443. This PR restricts PyTorch Hub models to simply using augment option.

You can visualize models with python detect.py --visualize and you can profile model yamls with python models/yolo.py --profile or --line-profile

To receive this update:

  • Gitgit pull from within your yolov5/ directory or git clone https://github.com/ultralytics/yolov5 again
  • PyTorch Hub – Force-reload model = torch.hub.load('ultralytics/yolov5', 'yolov5s', force_reload=True)
  • Notebooks – View updated notebooks Open In Colab Open In Kaggle
  • Dockersudo docker pull ultralytics/yolov5:latest to update your image Docker Pulls

Thank you for spotting this issue and informing us of the problem. Please let us know if this update resolves the issue for you, and feel free to inform us of any other issues you discover or feature requests that come to mind. Happy trainings with YOLOv5 🚀!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants