Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V 3.0 tag pointing to wrong commit #907

Closed
lorenzomammana opened this issue Sep 3, 2020 · 4 comments
Closed

V 3.0 tag pointing to wrong commit #907

lorenzomammana opened this issue Sep 3, 2020 · 4 comments
Labels
bug Something isn't working Stale

Comments

@lorenzomammana
Copy link
Contributor

lorenzomammana commented Sep 3, 2020 •
edited
Loading

🐛 Bug

The 3.0 release is pointing to commit 1ddf692, which is one commit before the actual v3.0 release, so if someone clones the repo from the v3.0 version is actually using the older version.

To Reproduce (REQUIRED)

Click on the tag commit.

Expected behavior

It should point towards commit 916d4aa
@lorenzomammana lorenzomammana added the bug Something isn't working label Sep 3, 2020
@glenn-jocher
Copy link
Member

glenn-jocher commented Sep 3, 2020 •
edited
Loading

@lorenzomammana thanks, it looks like you are right. Unfortunately I'm unable to change the commit associated with the release after publishing it, and it seems like I can only issue a new release associated with recent commits (i.e. within the last 10 commits). I'm not sure there's anything I can do about this now.

@lorenzomammana
Copy link
Contributor Author

Something like this?
https://github.community/t/create-releases-for-old-commits/872

glenn-jocher referenced this issue Sep 4, 2020
@tkianai
Update readme to remove apex dependency (#727)
1ddf692 
* the value should be a list to unpacking

* filter the None labels

* update readme to remove apex dependency
@glenn-jocher
Copy link
Member

I tried it but it was too complicated, will take better care going forward for next release.

@elepherai elepherai mentioned this issue Sep 10, 2020
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lorenzomammana @glenn-jocher