Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About pyotrch version #8581

Closed
1 task done
WesternTrail opened this issue Jul 15, 2022 · 6 comments · Fixed by #8621
Closed
1 task done

About pyotrch version #8581

WesternTrail opened this issue Jul 15, 2022 · 6 comments · Fixed by #8621
Labels
question Further information is requested

Comments

@WesternTrail
Copy link

WesternTrail commented Jul 15, 2022

Search before asking

Question

There will be errors when the previous version runs. The individual reason is that torch version 1.12.0. I noticed that the torch version is required in the requirement for this update != 1.12.0 to avoid errors during program operation. Actually, I'm running train Py file, the program will automatically check my torch Version (requirements: torch! =1.12.0, >=1.7.0 not found and is required by yolov5, attempting auto update...) And update the torch version. But this update directly installed my torch into the torch1.11.0-CPU version, resulting in a slow training speed. I think you should optimize the code itself rather than limit the torch version, because it will cause a lot of trouble

Additional

No response

@WesternTrail WesternTrail added the question Further information is requested label Jul 15, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 15, 2022

👋 Hello @WesternTrail, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset images, training logs, screenshots, and a public link to online W&B logging if available.

For business inquiries or professional support requests please visit https://ultralytics.com or email support@ultralytics.com.

Requirements

Python>=3.7.0 with all requirements.txt installed including PyTorch>=1.7. To get started:

git clone https://github.com/ultralytics/yolov5  # clone
cd yolov5
pip install -r requirements.txt  # install

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

CI CPU testing

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training (train.py), validation (val.py), inference (detect.py) and export (export.py) on macOS, Windows, and Ubuntu every 24 hours and on every commit.

@zhiqwang
Copy link
Contributor

zhiqwang commented Jul 15, 2022

In favor of not ruling out PyTorch 1.12.0, seems that PyTorch 1.12.0 only have problem for cuda10.2 and some other scenarios, but there are also a lot of people don't use cuda10.2 or don't meet this scenarios today.

@glenn-jocher
Copy link
Member

@WesternTrail the torch 1.12 incompatibilities are mainly observed in DDP trainings, but we have introduced this change in requirements.txt and are waiting for 1.12.1 to come out which should hopefully resolve these issues.

If you are not using DDP or cuda 10.2 you should be fine to simply comment out this line in requirements.txt

@glenn-jocher
Copy link
Member

@zhiqwang @WesternTrail alternatively we could also introduce an assert torch!=1.12.0 in DDP training with a message to the user to explain the problem.

@zhiqwang
Copy link
Contributor

zhiqwang commented Jul 15, 2022

alternatively we could also introduce an assert torch!=1.12.0 in DDP training with a message to the user to explain the problem.

@glenn-jocher Agreed on this option!

@glenn-jocher glenn-jocher linked a pull request Jul 18, 2022 that will close this issue
@glenn-jocher glenn-jocher removed the TODO label Jul 18, 2022
@glenn-jocher
Copy link
Member

@zhiqwang good news 😃! Your original issue may now be fixed ✅ in PR #8621. torch==1.12.0 installs are now allowed, and an assert torch!=1.12.0 has been inserted into a new smart_DDP() function. The Docker image is using torch nightly and trains DDP correctly.

To receive this update:

  • Gitgit pull from within your yolov5/ directory or git clone https://github.com/ultralytics/yolov5 again
  • PyTorch Hub – Force-reload model = torch.hub.load('ultralytics/yolov5', 'yolov5s', force_reload=True)
  • Notebooks – View updated notebooks Open In Colab Open In Kaggle
  • Dockersudo docker pull ultralytics/yolov5:latest to update your image Docker Pulls

Thank you for spotting this issue and informing us of the problem. Please let us know if this update resolves the issue for you, and feel free to inform us of any other issues you discover or feature requests that come to mind. Happy trainings with YOLOv5 🚀!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants