Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask Memory Release Error #7288

Closed
1 of 2 tasks
celalettinbilgen opened this issue Apr 5, 2022 · 9 comments · Fixed by #7289 or #7309
Closed
1 of 2 tasks

Flask Memory Release Error #7288

celalettinbilgen opened this issue Apr 5, 2022 · 9 comments · Fixed by #7289 or #7309
Labels
bug Something isn't working

Comments

@celalettinbilgen
Copy link

Search before asking

  • I have searched the YOLOv5 issues and found no similar bug report.

YOLOv5 Component

Detection, Integrations, Other

Bug

When using a flask, the memory is constantly increasing. I add the memory usage in the image below. I am using official Flask example. I see that the memory increases as I use the web service.

image

Environment

  • OS = Ubuntu
  • Pytorch CPU / latest version YoloV5

Minimal Reproducible Example

No response

Additional

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@celalettinbilgen celalettinbilgen added the bug Something isn't working label Apr 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2022

👋 Hello @celalettinbilgen, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset images, training logs, screenshots, and a public link to online W&B logging if available.

For business inquiries or professional support requests please visit https://ultralytics.com or email support@ultralytics.com.

Requirements

Python>=3.7.0 with all requirements.txt installed including PyTorch>=1.7. To get started:

git clone https://github.com/ultralytics/yolov5  # clone
cd yolov5
pip install -r requirements.txt  # install

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

CI CPU testing

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training (train.py), validation (val.py), inference (detect.py) and export (export.py) on MacOS, Windows, and Ubuntu every 24 hours and on every commit.

@glenn-jocher
Copy link
Member

@celalettinbilgen good news 😃! Your original issue may now be fixed ✅ in PR #7289. This PR implements context managers when opening files to properly close them after use.

To receive this update:

  • Gitgit pull from within your yolov5/ directory or git clone https://github.com/ultralytics/yolov5 again
  • PyTorch Hub – Force-reload model = torch.hub.load('ultralytics/yolov5', 'yolov5s', force_reload=True)
  • Notebooks – View updated notebooks Open In Colab Open In Kaggle
  • Dockersudo docker pull ultralytics/yolov5:latest to update your image Docker Pulls

Thank you for spotting this issue and informing us of the problem. Please let us know if this update resolves the issue for you, and feel free to inform us of any other issues you discover or feature requests that come to mind. Happy trainings with YOLOv5 🚀!

@celalettinbilgen
Copy link
Author

Thank you @glenn-jocher .

Unfortunately, I see that the problem still persists. The problem is in the restapi.py file, not the request script. Memory keeps increasing as I use it :(

@glenn-jocher glenn-jocher linked a pull request Apr 6, 2022 that will close this issue
@glenn-jocher
Copy link
Member

@celalettinbilgen could you try PR #7309 to see if this helps?

git clone https://github.com/ultralytics/yolov5 -b update/restapi

@glenn-jocher
Copy link
Member

glenn-jocher commented Apr 6, 2022

I think this may be related to opening may PIL Images without closing them, per https://pillow.readthedocs.io/en/stable/reference/open_files.html

If the PR doesn't work try the alternative implementations in the PIL docs until something works, and then let us know. Thanks!

@celalettinbilgen
Copy link
Author

@glenn-jocher

official sample not working :(

image

@glenn-jocher
Copy link
Member

@celalettinbilgen got it! Please debug this by editing https://github.com/ultralytics/yolov5/pull/7309/files per https://pillow.readthedocs.io/en/stable/reference/open_files.html to see if you can find a suitable solution.

@celalettinbilgen
Copy link
Author

@glenn-jocher I understand you very well. However, when I debug, the error I posted above is present. I pulled 7309.

@glenn-jocher
Copy link
Member

glenn-jocher commented Apr 7, 2022

@celalettinbilgen yes I understand. Please modify the code yourself to see if you can find a suitable solution per https://pillow.readthedocs.io/en/stable/reference/open_files.html, and then please submit a PR.

Please see our ✅ Contributing Guide to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants