Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error using YouTube address in detect.py #7241

Closed
1 of 2 tasks
makino-hashimoto-books opened this issue Apr 1, 2022 · 5 comments · Fixed by #7242
Closed
1 of 2 tasks

Error using YouTube address in detect.py #7241

makino-hashimoto-books opened this issue Apr 1, 2022 · 5 comments · Fixed by #7242
Labels
bug Something isn't working

Comments

@makino-hashimoto-books
Copy link

makino-hashimoto-books commented Apr 1, 2022

Search before asking

  • I have searched the YOLOv5 issues and found no similar bug report.

YOLOv5 Component

Detection

Bug

If source is set to YouTube address in detect.py, following error is shown.

Error message:
Traceback (most recent call last):
File "detect.py", line 252, in
main(opt)
File "detect.py", line 247, in main
run(**vars(opt))
File "/usr/local/lib/python3.7/dist-packages/torch/autograd/grad_mode.py", line 28, in decorate_context
return func(*args, **kwargs)
File "detect.py", line 100, in run
dataset = LoadStreams(source, img_size=imgsz, stride=stride, auto=pt)
File "/content/yolov5/utils/datasets.py", line 325, in init
assert cap.isOpened(), f'{st}Failed to open {s}'

Solve:
utils/dataset.py

if urlparse(s).hostname in ('youtube.com', 'youtu.be'): # if source is YouTube video
->
if urlparse(s).hostname in ('www.youtube.com', 'youtu.be'): # if source is YouTube video

Environment

  • google colab.

!python detect.py --weights yolov5s.pt --source https://www.youtube.com/watch?v=xxxxxxxx

No response

Additional

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@makino-hashimoto-books makino-hashimoto-books added the bug Something isn't working label Apr 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 1, 2022

👋 Hello @makino-hashimoto-books, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset images, training logs, screenshots, and a public link to online W&B logging if available.

For business inquiries or professional support requests please visit https://ultralytics.com or email support@ultralytics.com.

Requirements

Python>=3.7.0 with all requirements.txt installed including PyTorch>=1.7. To get started:

git clone https://github.com/ultralytics/yolov5  # clone
cd yolov5
pip install -r requirements.txt  # install

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

CI CPU testing

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training (train.py), validation (val.py), inference (detect.py) and export (export.py) on MacOS, Windows, and Ubuntu every 24 hours and on every commit.

@glenn-jocher
Copy link
Member

glenn-jocher commented Apr 1, 2022

@makino-hashimoto-books YouTube inference works correctly for me in Google Colab.

Screenshot 2022-04-01 at 21 27 23

We've created a few short guidelines below to help users provide what we need in order to start investigating a possible problem.

How to create a Minimal, Reproducible Example

When asking a question, people will be better able to provide help if you provide code that they can easily understand and use to reproduce the problem. This is referred to by community members as creating a minimum reproducible example. Your code that reproduces the problem should be:

  • Minimal – Use as little code as possible to produce the problem
  • Complete – Provide all parts someone else needs to reproduce the problem
  • Reproducible – Test the code you're about to provide to make sure it reproduces the problem

For Ultralytics to provide assistance your code should also be:

  • Current – Verify that your code is up-to-date with GitHub master, and if necessary git pull or git clone a new copy to ensure your problem has not already been solved in master.
  • Unmodified – Your problem must be reproducible using official YOLOv5 code without changes. Ultralytics does not provide support for custom code ⚠️.

If you believe your problem meets all the above criteria, please close this issue and raise a new one using the 🐛 Bug Report template with a minimum reproducible example to help us better understand and diagnose your problem.

Thank you! 😃

@glenn-jocher
Copy link
Member

@makino-hashimoto-books nevermind, you are correct, there is an error with the URL you supplied. Your fix looks good. I will implement a PR.

@glenn-jocher glenn-jocher linked a pull request Apr 1, 2022 that will close this issue
@makino-hashimoto-books
Copy link
Author

Thank you for solving method.

In the previous version, "www.youtube.com" was permitted.
Recently, the source file is changed, "www.youtube.com" is not permitted.

Previous version,
if 'youtube.com/' in s or 'youtu.be/' in s: # if source is YouTube video

Latest version
if urlparse(s).hostname in ('youtube.com', 'youtu.be'): # if source is YouTube video

@glenn-jocher
Copy link
Member

@makino-hashimoto-books good news 😃! Your original issue may now be fixed ✅ in PR #7242. This PR adds www.youtube.com to the valid hostname list alongside the existing youtube.com and youtu.be. This would allow you to pass youtube.com URLs with or without the www, but you always need the https://, i.e. https://www.youtube.com or https://youtube.com or https://youtu.be are all valid now :)

To receive this update:

  • Gitgit pull from within your yolov5/ directory or git clone https://github.com/ultralytics/yolov5 again
  • PyTorch Hub – Force-reload model = torch.hub.load('ultralytics/yolov5', 'yolov5s', force_reload=True)
  • Notebooks – View updated notebooks Open In Colab Open In Kaggle
  • Dockersudo docker pull ultralytics/yolov5:latest to update your image Docker Pulls

Thank you for spotting this issue and informing us of the problem. Please let us know if this update resolves the issue for you, and feel free to inform us of any other issues you discover or feature requests that come to mind. Happy trainings with YOLOv5 🚀!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants