Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Training crash on first validation: Error in processing validate dataset path #3644

Closed
thanhminhmr opened this issue Jun 16, 2021 · 3 comments · Fixed by #3646 or #5521
Closed

Training crash on first validation: Error in processing validate dataset path #3644

thanhminhmr opened this issue Jun 16, 2021 · 3 comments · Fixed by #3646 or #5521
Assignees
Labels
bug Something isn't working

Comments

@thanhminhmr
Copy link
Contributor

The tool crash while training from scratch, the trace point to this line in test.py.

Traceback (most recent call last):
  File "train.py", line 541, in <module>
    train(hyp, opt, device, tb_writer)
  File "train.py", line 367, in train
    compute_loss=compute_loss)
  File "/usr/local/lib/python3.7/dist-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/content/yolov5/test.py", line 81, in test
    is_coco = data['val'].endswith('coco/val2017.txt')  # COCO dataset
AttributeError: 'list' object has no attribute 'endswith'

yolov5/test.py

Line 81 in d808855

is_coco = data['val'].endswith('coco/val2017.txt') # COCO dataset

This is most likely an oversight in the code:
While the dataset file allows list of train/validation data sources (for example in coco128.yaml), the portion of code from above doesn't accept list.

# train and val data as 1) directory: path/images/, 2) file: path/images.txt, or 3) list: [path1/images/, path2/images/]

This is the related part of the dataset.yaml.

train: [/train/images/1/, /train/images/2/]
val: [/val/images/1/]

I'm unfamiliar with python so I cannot create a patch, but this should be a simple fix. (By adding type check before the endswith call)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2021

👋 Hello @thanhminhmr, thank you for your interest in 🚀 YOLOv5! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset images, training logs, screenshots, and a public link to online W&B logging if available.

For business inquiries or professional support requests please visit https://www.ultralytics.com or email Glenn Jocher at glenn.jocher@ultralytics.com.

Requirements

Python 3.8 or later with all requirements.txt dependencies installed, including torch>=1.7. To install run:

$ pip install -r requirements.txt

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

CI CPU testing

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training (train.py), testing (test.py), inference (detect.py) and export (export.py) on MacOS, Windows, and Ubuntu every 24 hours and on every commit.

@glenn-jocher
Copy link
Member

glenn-jocher commented Jun 16, 2021

@thanhminhmr thanks for the bug report! Yes this looks like a problem. This should be fixable by updating this line to:

is_coco = type(data['val']) is str and data['val'].endswith('coco/val2017.txt')  # COCO dataset

If this fix works well in your use case can you please submit a PR with it to help everyone else in the future? Thank you!

@glenn-jocher
Copy link
Member

@thanhminhmr good news 😃! Your original issue may now be fixed ✅ in PR #3646 and #5521. To receive this update:

  • Gitgit pull from within your yolov5/ directory or git clone https://github.com/ultralytics/yolov5 again
  • PyTorch Hub – Force-reload model = torch.hub.load('ultralytics/yolov5', 'yolov5s', force_reload=True)
  • Notebooks – View updated notebooks Open In Colab Open In Kaggle
  • Dockersudo docker pull ultralytics/yolov5:latest to update your image Docker Pulls

Thank you for spotting this issue and informing us of the problem. Please let us know if this update resolves the issue for you, and feel free to inform us of any other issues you discover or feature requests that come to mind. Happy trainings with YOLOv5 🚀!

@glenn-jocher glenn-jocher removed the TODO label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants