Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loss function like has a bug #1988

Closed
rrjia opened this issue Jan 20, 2021 · 5 comments
Closed

loss function like has a bug #1988

rrjia opened this issue Jan 20, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@rrjia
Copy link

rrjia commented Jan 20, 2021

🐛 Bug

A clear and concise description of what the bug is.

utils/loss.py line108

gain[2:6] = torch.tensor(p[i].shape)[[3, 2, 3, 2]]  # xyxy gain

for yolov5s.yaml
if i=1
p[i].shape = 3,80,80,85
gain[2:6] = [85, 80, 85, 80]

gain[2:6] = torch.tensor(p[i].shape)[[2, 1, 2, 1]]  # xyxy gain

it shoud be [80, 80, 80, 80]

@rrjia rrjia added the bug Something isn't working label Jan 20, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2021

👋 Hello @rrjia, thank you for your interest in 🚀 YOLOv5! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset images, training logs, screenshots, and a public link to online W&B logging if available.

For business inquiries or professional support requests please visit https://www.ultralytics.com or email Glenn Jocher at glenn.jocher@ultralytics.com.

Requirements

Python 3.8 or later with all requirements.txt dependencies installed, including torch>=1.7. To install run:

$ pip install -r requirements.txt

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

CI CPU testing

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training (train.py), testing (test.py), inference (detect.py) and export (export.py) on MacOS, Windows, and Ubuntu every 24 hours and on every commit.

@rrjia
Copy link
Author

rrjia commented Jan 20, 2021

image

@glenn-jocher
Copy link
Member

@rrjia hi thanks for the bug report and the screenshot! We have updated the loss function recently, creating a new ComputeLoss() class to replace it. Can you verify that you see the same bug in the most recent code please?

You can update your code with git pull, or alternatively you can git clone https://github.com/ultralytics/yolov5 again.

@glenn-jocher
Copy link
Member

@rrjia if I try to reproduce by training with default settings and placing a breakpoint here, everything looks correct:

Screen Shot 2021-01-20 at 9 53 34 AM

@rrjia
Copy link
Author

rrjia commented Jan 21, 2021

sorry it's my fault, the model get A list of length 3, i use y[0] input compute_loss function, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants