Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parameters freeze invalid #1213

Closed
densechen opened this issue Oct 26, 2020 · 1 comment
Closed

parameters freeze invalid #1213

densechen opened this issue Oct 26, 2020 · 1 comment

Comments

@densechen
Copy link

Hi, thanks for providing so nice code.
In this line, we set freeze parameters with requires_grad=False,

yolov5/train.py

Line 88 in 453acde

v.requires_grad = False

However, in the following line, all paremters have been set as requires_grad=True, which overwrite the previous settings.

yolov5/train.py

Line 97 in 453acde

v.requires_grad = True

@densechen densechen changed the title parameters freeze valid parameters freeze invalid Oct 26, 2020
@glenn-jocher
Copy link
Member

@densechen thank you for your feedback. This item is currently a TODO #679 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@densechen @glenn-jocher